Skip to content

Conversation

@adkafka
Copy link

@adkafka adkafka commented Jul 18, 2025

This is related to
#416. To use IAM Roles Anywhere, we will have a client certificate managed by a different cert-manager issuer. To reload the certificate when it is renewed, we need to be able to set annotations on the deployment (to make use of https://github.com/stakater/Reloader).

Validation:

$ helm template "foo" . --show-only templates/deployment.yaml  | head -n 20
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-aws-privateca-issuer
  namespace: default
  labels:
    helm.sh/chart: aws-privateca-issuer-v1.6.0
    app.kubernetes.io/name: aws-privateca-issuer
    app.kubernetes.io/instance: foo
    app.kubernetes.io/version: "v1.6.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 2
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  revisionHistoryLimit: 10
$ cat annotation.yaml
annotations:
  foo: bar
$ helm template "foo" . -f annotation.yaml --show-only templates/deployment.yaml  | head -n 20
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-aws-privateca-issuer
  namespace: default
  labels:
    helm.sh/chart: aws-privateca-issuer-v1.6.0
    app.kubernetes.io/name: aws-privateca-issuer
    app.kubernetes.io/instance: foo
    app.kubernetes.io/version: "v1.6.0"
    app.kubernetes.io/managed-by: Helm
  annotations:
    foo: bar
spec:
  replicas: 2
  strategy:
    type: RollingUpdate
    rollingUpdate:

Reason for this change

See above

Description of changes

See above

Describe any new or updated permissions being added

None

Description of how you validated changes

See above

This is related to
cert-manager#416. To use
IAM Roles Anywhere, we will have a client certificate managed by a
different cert-manager issuer. To reload the certificate when it is
renewed, we need to be able to set annotations on the deployment (to
make use of https://github.com/stakater/Reloader).

Validation:

```
$ helm template "foo" . --show-only templates/deployment.yaml  | head -n 20
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-aws-privateca-issuer
  namespace: default
  labels:
    helm.sh/chart: aws-privateca-issuer-v1.6.0
    app.kubernetes.io/name: aws-privateca-issuer
    app.kubernetes.io/instance: foo
    app.kubernetes.io/version: "v1.6.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 2
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  revisionHistoryLimit: 10
$ cat annotation.yaml
annotations:
  foo: bar
$ helm template "foo" . -f annotation.yaml --show-only templates/deployment.yaml  | head -n 20
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo-aws-privateca-issuer
  namespace: default
  labels:
    helm.sh/chart: aws-privateca-issuer-v1.6.0
    app.kubernetes.io/name: aws-privateca-issuer
    app.kubernetes.io/instance: foo
    app.kubernetes.io/version: "v1.6.0"
    app.kubernetes.io/managed-by: Helm
  annotations:
    foo: bar
spec:
  replicas: 2
  strategy:
    type: RollingUpdate
    rollingUpdate:
```

Signed-off-by: Adam Kafka <[email protected]>
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irbekrm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant